Skip to content

Remove broken health checks for now #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
temporal-nick merged 2 commits into from
Dec 2, 2025
Merged

Remove broken health checks for now #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ea3b3
Remove broken health checks for now
temporal-nick Dec 2, 2025
5cd7f3d
Remove unused code
temporal-nick Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions proxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,7 @@ func (s *Proxy) Start() error {
if s.inboundHealthCheckConfig != nil {
var err error
healthFn := func() bool {
// TODO: overly conservative right now. When there are multiple remotes, we should track their health separately
for _, cc := range s.clusterConnections {
if !cc.AcceptingInboundTraffic() {
return false
}
}
// TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check
Copy link
Collaborator

@hehaifengcn hehaifengcn Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not check-in commented code?

Copy link
Contributor Author

@temporal-nick temporal-nick Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, dropped the code

return true
}
if s.inboundHealthCheckServer, err = s.startHealthCheckHandler(s.lifetime, newInboundHealthCheck(healthFn, s.logger), *s.inboundHealthCheckConfig); err != nil {
Expand All @@ -143,12 +138,7 @@ func (s *Proxy) Start() error {

if s.outboundHealthCheckConfig != nil {
healthFn := func() bool {
// TODO: overly conservative right now. When there are multiple remotes, we should track their health separately
for _, cc := range s.clusterConnections {
if !cc.AcceptingOutboundTraffic() {
return false
}
}
// TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check
return true
}
var err error
Expand Down