Add support for Stand Alone Nexus Operations#639
Open
Quinn-With-Two-Ns wants to merge 3 commits intotemporalio:mainfrom
Open
Add support for Stand Alone Nexus Operations#639Quinn-With-Two-Ns wants to merge 3 commits intotemporalio:mainfrom
Quinn-With-Two-Ns wants to merge 3 commits intotemporalio:mainfrom
Conversation
…regenerate protos Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f5e019e68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE TO REVIEWERS: This PR is pending the actual release of the API and Server and will not be merged until those are complete.
Summary
(outside of workflows)
NexusWorkflowClient pattern
API Surface
On ITemporalClient:
On NexusClient:
On NexusOperationHandle:
All operations flow through the ClientOutboundInterceptor chain, consistent with stand-alone activities.
Test plan
Note
Medium Risk
Medium risk due to regenerated protobuf bindings and new enums/messages that expand public API surface; consumers may see compile-time warnings (new
[Obsolete]fields) and behavior changes when serializing/deserializing new fields.Overview
Adds new protobuf API surface to support standalone Nexus operations and worker compute configuration.
This regenerates protocol bindings to introduce
Temporalio.Api.Compute.V1(ComputeConfig,ComputeProvider,ComputeScaler), extends deployment/version protos to carrycompute_configpluslast_modifier_identity, and adds Nexus-related enums and error details (e.g.,NexusOperationExecutionAlreadyStartedFailure). It also extends common protos with a newLinkvariant fornexus_operationand introduces a server-derivedPrincipalmessage.Separately, marks several command
namespacefields as[Obsolete]due to cross-namespace deprecation, adds new event/worker-deployment status enum values, and updates OpenTelemetryTracingInterceptorto use the fully-qualifiedStartNexusOperationInputtype.Reviewed by Cursor Bugbot for commit 80d2428. Bugbot is set up for automated code reviews on this repo. Configure here.