Set completed_by_worker_shutdown field in matching poll responses#9551
Open
Set completed_by_worker_shutdown field in matching poll responses#9551
Conversation
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/poll-shutdown-rejected-field
branch
from
f8d8b48 to
e13248f
Compare
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/poll-shutdown-rejected-field
branch
2 times, most recently
from
4a806ee to
b2248b3
Compare
rkannan82
changed the title
Add `completed_by_worker_shutdown` bool field to the matching-internal poll response protos (workflow, activity, nexus). Refactor `pollTask` to return a `pollResult` struct so callers can propagate the shutdown signal to the response. Frontend propagation to the public API is pending an api dep bump. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/poll-shutdown-rejected-field
branch
from
afb6049 to
b78b2f8
Compare
2 tasks
Keep the field only on matching-internal protos for debugging. SDK already knows not to repoll, so no need to propagate to the public API at this time. Also fix pre-existing bug in matching_engine_test.go where two references to `task` were not renamed to `result.task`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
completed_by_worker_shutdownbool field to matching-internal poll response protos. When matching detects a poll from a shut-down worker, it sets this field in the response. The field is not propagated to the public API — it's for internal debugging of the frontend-to-matching RPCs.Why
Gives us visibility into whether matching is correctly rejecting re-polls from shut-down workers, without changing the public API.
How did you test it?
pollResultstruct andcompletedByShutdownbehavior.