docs: simplify TIP-1017 abstract, motivation, and notation#2873
Draft
docs: simplify TIP-1017 abstract, motivation, and notation#2873
Conversation
…C-67) The spec incorrectly stated that validator addresses must be globally unique across all validators including deleted ones. The actual implementation (and invariant tests) correctly enforce uniqueness only among active validators, allowing deactivated addresses to be reused. Updated tip-1017.md and IValidatorConfigV2.sol to reflect that: - Addresses are unique among active validators (reusable after deactivation) - Public keys remain globally unique (including deleted) Amp-Thread-ID: https://ampcode.com/threads/T-019c964b-0f84-721b-aac0-f08b136ae43f Co-authored-by: Amp <amp@ampcode.com>
Align TIP-1017 spec and Solidity ref-impl with the Rust V2 implementation which defines: error NotIpPort(string input, string backtrace); error NotIp(string input, string backtrace); Previously the spec and Solidity had an extra 'field' parameter that the Rust precompile never included. Resolves ZELLIC-65 Amp-Thread-ID: https://ampcode.com/threads/T-019c974c-ecce-74e1-bec5-2ecec8c53ee6 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
from
fa70e4b to
22d5bdc
Compare
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412
howydev
force-pushed
the
howy/simplify-tip1017-spec
branch
from
fe61eb0 to
dba60eb
Compare
📊 Tempo Precompiles Coverage |
Amp-Thread-ID: https://ampcode.com/threads/T-019c975c-5086-76f9-8908-fde47394f412 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Work in progress]
Shortens the abstract and motivation sections of TIP-1017, and replaces
abi.encodePackednotation with||concatenation for readability.