Remove unsupported --disable-thread-pinning flag#2882
Open
beck042 wants to merge 1 commit intotempoxyz:mainfrom
Open
Remove unsupported --disable-thread-pinning flag#2882beck042 wants to merge 1 commit intotempoxyz:mainfrom
--disable-thread-pinning flag#2882beck042 wants to merge 1 commit intotempoxyz:mainfrom
Conversation
The README (tempo/bin/tempo-bench/README.md) for the MacOS example run-max-tps specifies the `--disable-thread-pinning` flag, which is not present in the actual CLI. - The `--disable-thread-pinning` flag has been removed from the example for MacOS. - The example has been left working with the supported options: ```bash tempo-bench run-max-tps --duration 15 --tps 20000 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README (tempo/bin/tempo-bench/README.md) for the MacOS example run-max-tps specifies the
--disable-thread-pinningflag, which is not present in the actual CLI.--disable-thread-pinningflag has been removed from the example for MacOS.