feat(keychain): add AccessKeySpend event gated behind T2#2914
Open
feat(keychain): add AccessKeySpend event gated behind T2#2914
Conversation
Emits AccessKeySpend(account, publicKey, token, amount, remainingLimit) whenever an access key's spending limit is deducted in verify_and_update_spending. Gated behind is_t2() so it only applies from the T2 hardfork onwards. Amp-Thread-ID: https://ampcode.com/threads/T-019ca568-c744-717d-8a12-f5f80fc6c78e Co-authored-by: Amp <amp@ampcode.com>
decofe
requested review from
0xKitsune,
0xrusowsky,
dankrad,
danrobinson,
fgimenez,
howydev,
klkvr,
legion2002 and
mattsse
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emits
AccessKeySpend(account, publicKey, token, amount, remainingLimit)fromverify_and_update_spendingwhenever an access key's spending limit is deducted. Gated behindis_t2().Only fires for actual access-key spends — root key txs (
key_id == Address::ZERO) return early before reaching the emission point.Prompted by: tanishk