refactor(payload): extract pool selection stats and metrics helpers#3029
Closed
refactor(payload): extract pool selection stats and metrics helpers#3029
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
yongkangc
force-pushed
the
codex/payload-builder-refactor-1773027254
branch
from
bb12910 to
10f3b4d
Compare
Moves inline closures for pool-selection and subblock metrics recording into private methods on TempoPayloadBuilder, and groups the three pool tx counters into a PoolSelectionStats struct. Amp-Thread-ID: https://ampcode.com/threads/T-019cd0b8-c12a-7637-8025-02758360f9df
yongkangc
force-pushed
the
codex/payload-builder-refactor-1773027254
branch
from
10f3b4d to
e342e86
Compare
yongkangc
changed the title
Member
|
Closing — this incremental cleanup doesn't move the needle enough on its own. Going straight to the full phase pipeline refactor instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves inline closures for pool-selection and subblock metrics recording
into private methods on
TempoPayloadBuilder, and groups the three pooltx counters into a
PoolSelectionStatsstruct.No behavior changes — same metrics, same return types, same side effects.