Ensure that Oom failure reason is propagated correctly. #1840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When an allocation fails because of an out of memory, the failure reason is set at Oom. This reason is not propagated to the RequestCtx, which remains as FunctionError. We need to ensure that the failure reason in a request that ran out of memory is the right one.
What
Update the transformation of Oom failures in allocation to request failure reasons. I've also added a test to check the this is correct.
Testing
There is a new test that checks that the failure reason for a request is OutOfMemory when the allocation failure reason is Oom.
Contribution Checklist
make fmtin the package directory.make fmtinserver/.Note
Propagates OutOfMemory failures from function runs/allocations to request outcomes and HTTP API, adding the enum variant, mappings, and a verification test.
OutOfMemorytoRequestFailureReasonand include inDisplay.FunctionRunFailureReason::OutOfMemorytoRequestFailureReason::OutOfMemoryinFrom<...>conversion.out_of_memoryinRequestFailureReasonand update conversion fromdata_model.test_request_failure_reason_out_of_memoryvalidating propagation toRequestCtx,FunctionRun, andAllocationoutcomes.Written by Cursor Bugbot for commit 5c36078. This will update automatically on new commits. Configure here.