added more flexibility to public interface around heartbeating#78
Open
virajmehta wants to merge 3 commits intomainfrom
Open
added more flexibility to public interface around heartbeating#78virajmehta wants to merge 3 commits intomainfrom
virajmehta wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Public API changes to
TaskContext::stepand heartbeat plumbing could require downstream updates and may affect lease-extension behavior if incorrectly wired, though the underlying DB call remains the same.Overview
Adds a new
heartbeatmodule introducing aHeartbeatertrait plusHeartbeatHandle(real DB-backed lease extension) andNoopHeartbeater(test/no-op), and re-exports these types fromlib.rs.Updates
TaskContextto own a cloneableHeartbeatHandle, delegateTaskContext::heartbeat()to it, and exposeTaskContext::heartbeat_handle()for passing heartbeating into other helpers.Changes
TaskContext::stepso step closures receiveStepState<State>(wrapping the userstateplus anArc<dyn Heartbeater>), enabling heartbeats during long-running step execution; tests are updated to usestep_state.state.Written by Cursor Bugbot for commit 9c60a6d. This will update automatically on new commits. Configure here.