This repository was archived by the owner on Jul 20, 2023. It is now read-only.
fix: seek method did notify delegate to early#109
Open
rabrschmidt wants to merge 2 commits intoteodorpatras:masterfrom
Open
fix: seek method did notify delegate to early#109rabrschmidt wants to merge 2 commits intoteodorpatras:masterfrom
rabrschmidt wants to merge 2 commits intoteodorpatras:masterfrom
Conversation
When seeking the jukebox didn't wait for AVPlayer to finish seeking before notifying delegate. When delegate receives this message, progress is still on state before seeking. AVPlayer offers a method with completionBlock, which is called when seeking is finished. Using this completionBlock to notify the delegate resolves some issues with seeking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When seeking the jukebox didn't wait for AVPlayer to finish seeking before notifying delegate.
When delegate receives this message, progress is still on state before seeking.
AVPlayer offers a method with completionBlock, which is called when seeking is finished.
Using this completionBlock to notify the delegate resolves some issues with seeking.