This repository was archived by the owner on Jul 20, 2023. It is now read-only.
Moved Creation of AVURLAsset to background thread. #67
Open
joelmbell wants to merge 1 commit intoteodorpatras:masterfrom
Open
Moved Creation of AVURLAsset to background thread. #67joelmbell wants to merge 1 commit intoteodorpatras:masterfrom
joelmbell wants to merge 1 commit intoteodorpatras:masterfrom
Conversation
AVURLAsset has some undocumented behavior where passing specific url's to it with the AVAsset(url:) initializer will cause main thread stalls. I simply moved the creation of this object onto a background thread to avoid any of these potential stalls happening on the main thread.
joelmbell
changed the title
Author
|
Hmm, not sure why the build failed. All tests pass locally. Please let me know if there is anything I should be doing differently to get this to pass. I'd happily update the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #57
AVURLAsset has some undocumented behavior where passing specific url's
to it with the AVAsset(url:) initializer will cause main thread stalls.
I simply moved the creation of this object onto a background thread to
avoid any of these potential stalls happening on the main thread.