Open
Conversation
added 7 commits
October 1, 2025 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr aims to resolve UX issues when registering composite authenticators. Specifically, SubAuthenticators config data ends up as raw binary in UI's of wallets when a user is adding a composite authenticator (
anyOf,allOf). This is a security vector that limits the verification of what a user is actually approving, especially for such a critical action like delegated authorization of actions for a users wallet.The solution is to update the config values expected for
MsgAddAuthenticatorto replacedatabyes expected withAuthenticatorConfig, that defines a oneOf parameter for either raw string or bytes (preserving backwards compatibility).This allows authenticators to retain the decision on how to compose the data structure set in its parameters, for example here is what the
SignatureVerificationexpects to be passed as the config data when adding an authenticator: