Skip to content

Conversation

@Aditya-ranjan-16
Copy link

Description

Add regex validation in ibm_Catalog.json

Git_issue:https://github.ibm.com/GoldenEye/issues/issues/16144

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add regex validation in ibm_catalog.json

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya-ranjan-16 As part of this PR could you also please:

  • Update resource group input like so:
    variable "existing_resource_group_name" {
      type        = string
      description = "The name of an existing resource group to provision the resources. [Learn more](https://cloud.ibm.com/docs/account?topic=account-rgs&interface=ui#create_rgs) about how to create a resource group."
      default     = "Default"
    }
    
  • Remove the default_value and description from the "existing_resource_group_name" input in the ibm_catalog.json

@Aditya-ranjan-16
Copy link
Author

@Aditya-ranjan-16 As part of this PR could you also please:

  • Update resource group input like so:
    variable "existing_resource_group_name" {
      type        = string
      description = "The name of an existing resource group to provision the resources. [Learn more](https://cloud.ibm.com/docs/account?topic=account-rgs&interface=ui#create_rgs) about how to create a resource group."
      default     = "Default"
    }
    
  • Remove the default_value and description from the "existing_resource_group_name" input in the ibm_catalog.json

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants