Draft
Conversation
alexkaratarakis
force-pushed
the
reflection_customization
branch
from
07a10eb to
5336fe7
Compare
Bobobalink
reviewed
Dec 4, 2024
Contributor
Bobobalink
left a comment
Bobobalink
left a comment
There was a problem hiding this comment.
I am conflicted on having FIELD_NAMES and for_each_field be the two things that you can customize. They are definitely the "important" ones, but if we have these two then why not also have as_tuple_view?
Then at the point we have as_tuple_view and FIELD_NAMES, should we just always use the default impl of for_each_field? Probably not because the codegen for_each_field will be far more efficient than tuples::for_each_entry, but it feels bad to have 2-3 duplicated sets of the same information...
alexkaratarakis
force-pushed
the
reflection_customization
branch
4 times, most recently
from
bd32629 to
1919e78
Compare
This is useful e.g. in really big structs that can have reflection info provided by codegen
alexkaratarakis
force-pushed
the
reflection_customization
branch
from
1919e78 to
36438b2
Compare
alexkaratarakis
force-pushed
the
reflection_customization
branch
from
29e7181 to
a376680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.