feat: Add ResizeExecTtyAsync to IExecOperations#68
Open
j4587698 wants to merge 2 commits intotestcontainers:mainfrom
Open
feat: Add ResizeExecTtyAsync to IExecOperations#68j4587698 wants to merge 2 commits intotestcontainers:mainfrom
j4587698 wants to merge 2 commits intotestcontainers:mainfrom
Conversation
Add the missing exec TTY resize API (POST /exec/{id}/resize) to
IExecOperations and ExecOperations, mirroring the existing
ResizeContainerTtyAsync in ContainerOperations.
Docker Engine API supports resizing exec instances via
POST /exec/{id}/resize?h={height}&w={width}, but this endpoint
was not exposed in the SDK. This makes it impossible to properly
resize terminal sessions created via exec without resorting to
raw HTTP requests or workarounds like stty commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the missing ResizeExecTtyAsync method to IExecOperations, which maps to POST /exec/{id}/resize in the Docker Engine API. This allows resizing the TTY of a running exec instance — essential for interactive terminal sessions (e.g., docker exec -it).
Changes