Replace deprecated MSSQLServerContainer in ServiceBusEmulatorContainer#11379
Closed
minsang-alt wants to merge 1 commit intotestcontainers:mainfrom
Closed
Replace deprecated MSSQLServerContainer in ServiceBusEmulatorContainer#11379minsang-alt wants to merge 1 commit intotestcontainers:mainfrom
minsang-alt wants to merge 1 commit intotestcontainers:mainfrom
Conversation
Member
|
Thanks for your contribution, @minsang-alt. But I am closing this one in favor of #11223, which was submitted first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace deprecated
org.testcontainers.containers.MSSQLServerContainerwithorg.testcontainers.mssqlserver.MSSQLServerContainerinServiceBusEmulatorContainer.Changes
<?>) as the new class doesn't use themRelated Issue
Fixes #11373
Breaking Change
This changes the method signature of
withMsSqlServerContainer().Users passing the deprecated
MSSQLServerContainerwill need to migrateto the new class. Since the old class is already deprecated, this aligns
with the intended migration path.