Skip to content

Fix default wait_for when port_bindings are specified #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mchwalek wants to merge 2 commits into from
Closed

Fix default wait_for when port_bindings are specified #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54e111
Fix default wait_for when port_bindings are specified
mchwalek Oct 7, 2025
2c8521c
Fix style
mchwalek Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion postgres/lib/testcontainers/postgres.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def initialize(image = POSTGRES_DEFAULT_IMAGE, username: nil, password: nil, dat
@password = password || ENV.fetch("POSTGRES_PASSWORD", POSTGRES_DEFAULT_PASSWORD)
@database = database || ENV.fetch("POSTGRES_DATABASE", POSTGRES_DEFAULT_DATABASE)
@healthcheck ||= add_healthcheck(_default_healthcheck_options)
@wait_for ||= add_wait_for(:healthcheck)
@wait_for = add_wait_for(:healthcheck) if !@wait_for || !kwargs[:wait_for]
Copy link
Contributor Author

@mchwalek mchwalek Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether I should get the param from kwargs or just specify it in the constructor

end

# Starts the container
Expand Down
14 changes: 14 additions & 0 deletions postgres/test/postgres_container_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,18 @@ def test_it_is_reachable
client = PG.connect(host: @host, user: "test", password: "test", port: @port, dbname: "test")
assert_equal({"number" => "1"}, client.exec("SELECT 1 AS number").first)
end

def test_it_uses_wait_for_healthcheck_by_default
expected_wait_for = Testcontainers::PostgresContainer.new(wait_for: :healthcheck).wait_for
actual_wait_for = Testcontainers::PostgresContainer.new.wait_for

assert_equal expected_wait_for.source_location, actual_wait_for.source_location
end

def test_it_uses_wait_for_healthcheck_by_default_when_port_bindings_are_specified
expected_wait_for = Testcontainers::PostgresContainer.new(wait_for: :healthcheck).wait_for
actual_wait_for = Testcontainers::PostgresContainer.new(port_bindings: {"5432": "15432"}).wait_for

assert_equal expected_wait_for.source_location, actual_wait_for.source_location
end
end
Loading