feat: added support for filtering by download URL (macOS only) #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for filtering files on macOS by using the `kMDItemWhereFroms` metadata present in files downloaded. The testcase is a little scuffed as processing file metadata requires the file to be in a location where Spotlight will reindex, and by default Spotlight does not index `/tmp` and `/private/var/tmp` Also, `osxmetadata` is currently pinned to 1.3.0 due to some issues with dependencies for 1.4.0
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using Hazel during the 5.x versions and relied quite heavily on the ability to sort files by where they were downloaded from.
This commit adds support for filtering files on macOS by using the
kMDItemWhereFromsmetadata present in files downloaded.The testcase is a little scuffed as processing file metadata requires the file to be in a location where Spotlight will reindex, and by default Spotlight does not index
/tmpand/private/var/tmpAlso,
osxmetadatais currently pinned to 1.3.0 due to some issues with dependencies for 1.4.0Let me know if there's anything I should edit! :)
Change Summary
macos_downloadsourceas a filterRelated issue number
Not that I'm aware of
Checklist