format python source code using black; use loguru for status updates#2
Closed
Timothy-W-Hilton wants to merge 2 commits intotglauch:mainfrom
Closed
format python source code using black; use loguru for status updates#2Timothy-W-Hilton wants to merge 2 commits intotglauch:mainfrom
Timothy-W-Hilton wants to merge 2 commits intotglauch:mainfrom
Conversation
apply black formatter (https://black.readthedocs.io/en/stable/index.html) to Python source files. Ran black with default options in top-level pyVPRM directory (`black --verbose .`). versions used: black, 24.8.0 (compiled: no) Python (CPython) 3.12.5
replace "print(...)" with "loguru.logger.info(...)" provides time-stamps and source line attributions to progress updates. The time stamps are particularly useful for understanding which pieces are taking a long time on a long-running simulation. https://loguru.readthedocs.io/en/stable/index.html https://github.com/Delgan/loguru
Author
|
duplicate of #1 - sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formats Python source files using black formatting tool v24.8.0 with default options.
Uses loguru to write status updates to stdout. Changes all print() calls to loguru.logger.info(). This causes all the status updates to include a timestamp and the originating source line. The timestamps make it easier to understand which parts are taking a long time, or how long a pyVPRM task took if it was allowed to run unattended.