Breakout Room 1: Update main.py #1
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,23 @@ | ||
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): | ||
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
|
Collaborator
There was a problem hiding this comment. Note that the inputs are not properly validating entries. Check tests and for edge case inputs. |
||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
|
Collaborator
There was a problem hiding this comment. I suggest distinguishing that the user enters a 'second' noun, so they don't think it is a repeat or error.
Collaborator
There was a problem hiding this comment. Consider creating a helper function to manage the repeated request for a noun. |
||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
|
Collaborator
There was a problem hiding this comment. I suggest distinguishing that the user enters a 'third' noun, so they don't think the prompt is a repeat or error. |
||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
|
Collaborator
There was a problem hiding this comment. Consider combing the print statements into a single print statement that is a formatted string containing each variable.
Collaborator
There was a problem hiding this comment. The print statement could be separated into individual lines for each phrase. |
||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
|
Collaborator
There was a problem hiding this comment. ***Misspelled 'second' |
||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
|
Collaborator
There was a problem hiding this comment. Incorrect word order: 'this' and 'is' should be switched. |
||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 | ||
|
Collaborator
There was a problem hiding this comment. Refactor to state: loop += 1 |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider placing all input requests within a single function to create the desired output. A helper function could also be useful for repeated requestions.