WIP HBP-75 Merged plotting from tvb-scripts#100
WIP HBP-75 Merged plotting from tvb-scripts#100bogdanvalean1 wants to merge 1 commit intotvb-multiscale-cosimfrom
Conversation
|
Because @dionperd proposed to keep for the moment to the scripts on his branch ( https://req.thevirtualbrain.org/browse/HBP-75?focusedCommentId=17456&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17456 ) I created a PR dionperd/tvb-scripts#1 from a fork with some code cleanup after this merge. |
|
|
||
| def __init__(self, config=CONFIGURED): | ||
| self.config = config | ||
| def __init__(self, config=None): |
There was a problem hiding this comment.
The previous code allowed more unity in the configurations. Currently, the fresh Config() in case of missing init param is always "fresh"
| import numpy | ||
|
|
||
|
|
||
| class GenericConfig(object): |
| self._raw_data = raw_folder | ||
| self._data_mode = data_mode | ||
|
|
||
| class FiguresConfig(object): |
There was a problem hiding this comment.
We should have here under tvb.simulator.PLOT just a configuration for Figures. This is the single purpose for this module
| @@ -0,0 +1,62 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This type of main entrance to plotting might deserve to stay inside tvb_multiscale only
There was a problem hiding this comment.
After discussing with @dionperd we agreed to keep this here.
Then adding the license at the top will be needed.
|
We discussed to move these changes in a clean branch from master and try to merge there |
2 participants
I merged plot module from tvb-scripts into library