Skip to content

Tech Test Changes - James#27

Open
jcsabin wants to merge 1 commit intothebeansgroup:masterfrom
jcsabin:master
Open

Tech Test Changes - James#27
jcsabin wants to merge 1 commit intothebeansgroup:masterfrom
jcsabin:master

Conversation

@jcsabin
Copy link

@jcsabin jcsabin commented Oct 20, 2021

These are the changes are requested by the tech test a few things I would like to point out below.

  • With the images I wasn't given the ones for the design so placeholders were in their place. Also I've done the image as just an img tag rather than having an image container based on the premise that images wouldn't of been resized on the front-end as they would of already been pre formatted before being sent over.
  • Would of liked more details for font-weight and line-heights etc to get the finished product closer to design but unfortunately wasn't working from a mac so was unable to open SKETCH file.
  • Some of the numbers on the design were to 2 decimal places while others wasn't so I've stuck to what the design shows on this.
  • Date and Location labels under the donation percent were in capitals wasn't sure whether you wanted this hard coded or done through css.
  • Would also of added SCSS has this of been a bigger project to better manage the CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant