Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
Thanks for letting me have a go at that it was fun.
Wasn't sure how to handle the images as there seemed to be no obvious way of mapping a user to an image, so I just added the path in as an attribute in the data.
Another quick note about handling child comments; the way I did it only handles one level (e.g. wouldn't handle grand children). I figured it fell outside the scope of this as there was no grandchildren comments, but if it needed to be done there would be a few options, e.g. counting the amount of levels of ancestry you are going and incrementally increasing their distance from the left, or only having them show if you press show responses (depending on how you wanted to style it).
Look forward to hearing from you!
Elijah Burke.