BG2-3106: Withhold platoform fee (tip + fee) from charities when taki…#1915
Closed
BG2-3106: Withhold platoform fee (tip + fee) from charities when taki…#1915
Conversation
…ng payment via Ryft
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1915 +/- ##
===========================================
- Coverage 65.05% 64.79% -0.26%
===========================================
Files 195 195
Lines 9388 9426 +38
===========================================
+ Hits 6107 6108 +1
- Misses 3281 3318 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdsl
force-pushed
the
BG2-3106-platform-fee
branch
2 times, most recently
from
27d1044 to
fdede8f
Compare
bdsl
commented
Apr 2, 2026
In practice for now this is just going to be changes to the tip - I'm not sure if we have any way to do updates for changes to card brand or country.
bdsl
force-pushed
the
BG2-3106-platform-fee
branch
from
fdede8f to
94e49a5
Compare
NoelLH
reviewed
Apr 7, 2026
Comment on lines
+473
to
+476
| // For now this is still going to be always set a fee as if they're using the cheapest card type, | ||
| // i.e. EU/UK Visa/MasterCard. Since the ryft donations are initiated from the client side I'm | ||
| // not sure if we actually have any good way to vary fees according to card brand and country | ||
| // as we do with stripe. |
Contributor
There was a problem hiding this comment.
I think this seems fundamental enough that we should run it past their integration team, perhaps before going further with this.
Contributor
Author
|
superseded by #1920 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng payment via Ryft