Deal with #text nodes from whitespaces
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the build setup whitespaces potentially return a `#text` when querying for the first child node, instead, the system must ignore them and pick the node that the user intended to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the build setup whitespaces will potentially be turned into
#textnodes, so when querying for the first child node as the current code does it breaks the plugin. Instead, it should ignore#textnodes and pick the node that the user actually intended to be used.This change should not break setups where whitespaces are not kept and therefore turned into
#textnodes as if there's a single node, then the system will take that instance anyway (same as it used to do withfirstChild.See mdn reference.