Change city_lookup to load all configured cities

[duduribeiro]

Closes #67
There is a problem with city_lookup. It only loads the cities for the first statue you called cities on. This is because cities memoizes all the cities for the country, but city_lookup only loads the cities for the state, and doesn't get called again for the other states.

Ex:

having the following db/cities-lookup.yml:

BR:
  GO:
    "Mutunópolis": "Mutunópolis"

If I load first cities for other state, it does not include this missing city:

bin/rails c
CS.cities(:sp, :br) # loading another state first
CS.cities(:go, :br).include?("Mutunópolis")

=> false

returned false but it should be true.

If I load this state first, it works correctly

bin/rails c
CS.cities(:go, :br).include?("Mutunópolis")

=> true

This commit changes city_lookup to load all the cities for the country.

[viviancan]

@duduribeiro Hello 👋 Any updates on this^? We are facing a similar issue when trying to add cities using the cities-lookup file. I have successfully renamed a country and state using the country and state lookup files but have not been able to add a city. Thx!

[duduribeiro]

hey @viviancan 👋

I'm not a maintainer of the repo, so I can't merge.

What you can do is use this commit (like I'm doing in my app).

You can add this on your Gemfile

gem "city-state", github: "duduribeiro/city-state", branch: "fix-lookup-cities"

and check if it works on your case. It worked for me

[viviancan]

hey @viviancan 👋

I'm not a maintainer of the repo, so I can't merge.

What you can do is use this commit (like I'm doing in my app).

You can add this on your Gemfile

gem "city-state", github: "duduribeiro/city-state", branch: "fix-lookup-cities"

and check if it works on your case. It worked for me

@duduribeiro Thank you for the tip 😄 Hopefully there will be some feedback on this issue soon!

[duduribeiro]

hey @viviancan 👋
I'm not a maintainer of the repo, so I can't merge.
What you can do is use this commit (like I'm doing in my app).
You can add this on your Gemfile

gem "city-state", github: "duduribeiro/city-state", branch: "fix-lookup-cities"

and check if it works on your case. It worked for me

@duduribeiro Thank you for the tip 😄 Hopefully there will be some feedback on this issue soon!

Hey @viviancan 👋

I tried to reach @loureirorg about these but without success. I created a new gem https://github.com/duduribeiro/civitas https://rubygems.org/gems/civitas which contains these fixes and I will try to apply future fixes as well, since I use these gem. It is an easy drop-in replacement for city-state (just replace city-state to civitas in Gemfile). I know this is not the best scenario but it is how I followed to.