Break OSPL to test the Vale rule #4468
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Needs tech review
Contributor
|
I would have expected three comments by Vale. |
This was referenced Nov 13, 2025
apinnick
reviewed
Nov 18, 2025
| . On the *LDAP server* tab, enter the details of your LDAP server. | ||
| + | ||
| For TLS encrypted connections, select *LDAPS* to enable encryption. | ||
| . On the *LDAP server* tab, enter the details of your LDAP server. For TLS encrypted connections, select *LDAPS* to enable encryption. |
Contributor
There was a problem hiding this comment.
I think the rule is missing this occurrence because the second sentence does not end with a punctuation mark + space + character. It ends with a line break.
apinnick
reviewed
Nov 18, 2025
| You can configure your {Project} environment to use a load balancer to distribute host requests and network load across multiple {SmartProxyServers}. | ||
| This results in an improved performance on {SmartProxyServers} and improved performance and stability for host connections to {Project}. | ||
| You can configure your {Project} environment to use a load balancer to distribute host requests and network load across multiple {SmartProxyServers}. This results in an improved performance on {SmartProxyServers} and improved performance and stability for host connections to {Project}. | ||
| In a load-balanced setup, {SmartProxy} functionality supported for load balancing continues to work as expected when one {SmartProxyServer} is down for planned or unplanned maintenance. |
Contributor
There was a problem hiding this comment.
Same comment as below. I think the rule is not detecting the second sentence because it is followed immediately by a line break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: