-
Notifications
You must be signed in to change notification settings - Fork 108
Add permission prerequisites for Lightspeed IoP #4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocuments required permissions and prerequisites for using Lightspeed IoP, updating existing vulnerability examination and Insights access procedures to explicitly call out Lightspeed IoP–related access requirements. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `guides/common/modules/ref_access-to-information-from-insights-in-project.adoc:18` </location>
<code_context>
If the host has recommendations listed, click on the number of recommendations.
On the *{Insights}* tab, the vertical ellipsis next to the *Remediate* button provides a *Go To {Project} {Insights} page* link to information for the system, and a *View in {Insights}* link to host details on the console.
+
+Your {Project} account must have the `view_advisor` permission to view information from {Insights}.
</code_context>
<issue_to_address>
**suggestion (review_instructions):** This sentence is written as a product/permission statement rather than in a user-story style as requested.
To better align with the user-story style, consider rephrasing this to focus on what the user can do when they have this permission. For example, something along the lines of “As a user with the `view_advisor` permission, you can view information from {Insights} …” or similar wording that emphasizes the user’s goal and outcome rather than the permission as a product feature.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `guides/common/*.adoc,guides/common/modules/*.adoc`
**Instructions:**
Documentation describes a user story rather than a product feature.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
guides/common/modules/ref_access-to-information-from-insights-in-project.adoc
Outdated
Show resolved
Hide resolved
|
The PR preview for 69a2841 is available at theforeman-foreman-documentation-preview-pr-4523.surge.sh The following output files are affected by this PR: |
qcjames53
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Permissions match https://issues.redhat.com/browse/SAT-40632.
|
Thank you for reviews, folks! I'm gonna have to rebase this PR after #4524 will have been merged. It will look very differently, so I'm keeping the style ack open for now. :) |
14d2d7f to
6e41e5c
Compare
6e41e5c to
69a2841
Compare
|
Rebased. |
What changes are you introducing?
Adding permission prerequisites to Lightspeed IoP procedures
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
SAT-40633
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: N/A
Summary by Sourcery
Document permission prerequisites for accessing Lightspeed IoP features and related Insights information.
Documentation: