Fixes #38956 - Add cron rake tasks for recurring jobs #10784

archanaserver · 2025-11-27T06:04:47Z

Introduce Foreman::Cron with a hard-coded mapping from hourly/daily/weekly/monthly to existing rake tasks, and add cron:hourly, cron:daily, cron:weekly and cron:monthly rake tasks.

These serve as generic entrypoints for scheduling (e.g. systemd timers in foremanctl) instead of wiring individual tasks.

Related to: theforeman/foremanctl#288 (review)

lib/foreman/cron.rb

archanaserver · 2025-12-09T00:56:50Z

Also the failure looks unrelated to the changes

evgeni · 2025-12-09T09:26:33Z

Also the failure looks unrelated to the changes

Yepp, that's a regression in facterdb

lib/foreman/cron.rb

evgeni · 2025-12-09T14:35:06Z

The tests were fixed in #10794 -- if you rebase CI should turn green.

I think Foreman::Cron could use some tests too ;-)

archanaserver · 2025-12-10T06:57:04Z

I think Foreman::Cron could use some tests too ;-)

fair, working on it :/

lib/foreman/cron.rb

test/unit/foreman/cron_test.rb

evgeni · 2025-12-12T08:16:37Z

This needs a redmine, and the test setup fixed, but other than that it looks good!

Thanks!

archanaserver · 2025-12-15T08:16:07Z

This needs a redmine, and the test setup fixed, but other than that it looks good!

@evgeni seems like redmine is not accessible atm

evgeni · 2025-12-15T08:45:52Z

This needs a redmine, and the test setup fixed, but other than that it looks good!

@evgeni seems like redmine is not accessible atm

Fixed it now.

archanaserver · 2025-12-17T10:57:08Z

@evgeni i see that db fixture error is unrelated to this fix, and rest is working fine now.

test/unit/foreman/cron_test.rb

lib/foreman/cron.rb

lib/tasks/cron.rake

archanaserver · 2026-01-06T12:14:19Z

@evgeni sorry, i forgot looking at this PR earlier, so missed the comment, but thanks, updated now!

lib/foreman/cron.rb

Introduce `Foreman::Cron` with a hard-coded mapping from hourly/daily/weekly/monthly to existing rake tasks, and add `cron:hourly`, `cron:daily`, `cron:weekly` and `cron:monthly` rake tasks. These serve as generic entrypoints for scheduling (e.g. systemd timers in foremanctl) instead of wiring individual tasks. Allow plugins to register extra tasks in Foreman::Cron Fail cron:* rake tasks when a job fails Refine Foreman::Cron task Add unit tests for Foreman::Cron unified registry add section on scheduling recurring plugin tasks

evgeni · 2026-01-07T08:14:51Z

lib/tasks/cron.rake

+Foreman::Cron.register(:daily,  'reports:daily')
+Foreman::Cron.register(:daily,  'db:sessions:clear')
+Foreman::Cron.register(:daily,  'reports:expire')
+Foreman::Cron.register(:daily,  'audits:expire')


When testing this, I realized that the audits:expire task calls exit here:

foreman/lib/tasks/audits.rake

Lines 69 to 70 in d64ee4e

puts "The interval for keeping the Audits is not defined in the settings, exiting..."

exit 0

Which will abort the whole rake run and skip any follow up tasks, while exiting 0, so no error reporting happens.

I don't think we need to fix that in this PR, but something we should address before going live with this new framework.

that's right, thanks for pointing this out! but yeah let's keep this PR focused for wiring up the cron framework work we did, i'll follow up on another PR for refactor of both reports:* and audits:expire

evgeni · 2026-01-07T08:16:00Z

lib/tasks/cron.rake

+Foreman::Cron.register(:daily,  'reports:expire')
+Foreman::Cron.register(:daily,  'audits:expire')
+
+Foreman::Cron.register(:weekly, 'reports:weekly')


reports:* similarly uses exit, but it seems at least the default config is fine as it did not abort for me.

foreman/lib/tasks/reports.rake

Lines 83 to 84 in d64ee4e

$stdout.puts "Unable to find puppet environment=#{env}"

exit 1

foreman/lib/tasks/reports.rake

Lines 92 to 93 in d64ee4e

$stdout.puts "invalid fact #{ENV['fact']}"

exit 1

shubhamsg199

ACK, Tested and works as expected.

pr-processor bot added Not yet reviewed Waiting on contributor labels Nov 27, 2025

This was referenced Nov 27, 2025

update defaults to define 4 generic timers theforeman/foremanctl#332

Open

add quadlet recurring job runner and timers for core rake tasks theforeman/foremanctl#288

Merged

evgeni reviewed Dec 3, 2025

View reviewed changes

lib/foreman/cron.rb Outdated Show resolved Hide resolved

pr-processor bot added Needs re-review and removed Not yet reviewed Needs re-review labels Dec 3, 2025

adamruzicka reviewed Dec 9, 2025

View reviewed changes

lib/foreman/cron.rb Outdated Show resolved Hide resolved

adamruzicka reviewed Dec 9, 2025

View reviewed changes

lib/foreman/cron.rb Outdated Show resolved Hide resolved

lib/foreman/cron.rb Outdated Show resolved Hide resolved

archanaserver force-pushed the cron-rake-tasks branch from f1d3526 to 46d202e Compare December 10, 2025 06:35

pr-processor bot added the Needs re-review label Dec 10, 2025

archanaserver force-pushed the cron-rake-tasks branch from 46d202e to 7512c2f Compare December 10, 2025 06:47

archanaserver force-pushed the cron-rake-tasks branch from 7512c2f to 569dad9 Compare December 10, 2025 09:37

archanaserver requested review from adamruzicka and evgeni December 10, 2025 10:03

archanaserver force-pushed the cron-rake-tasks branch from 569dad9 to 1a8978d Compare December 11, 2025 09:42

evgeni reviewed Dec 12, 2025

View reviewed changes

lib/foreman/cron.rb Outdated Show resolved Hide resolved

pr-processor bot removed the Needs re-review label Dec 12, 2025

evgeni reviewed Dec 12, 2025

View reviewed changes

test/unit/foreman/cron_test.rb Outdated Show resolved Hide resolved

archanaserver force-pushed the cron-rake-tasks branch from 1a8978d to 58f2f81 Compare December 15, 2025 08:09

pr-processor bot added Needs re-review and removed Needs re-review labels Dec 15, 2025

archanaserver changed the title ~~Add cron rake tasks for recurring jobs~~ Fixes #38956 - Add cron rake tasks for recurring jobs Dec 15, 2025

archanaserver force-pushed the cron-rake-tasks branch from 58f2f81 to 97b3515 Compare December 15, 2025 10:13

pr-processor bot added Needs re-review and removed Waiting on contributor labels Dec 15, 2025

archanaserver force-pushed the cron-rake-tasks branch 2 times, most recently from c600fe2 to 43d493c Compare December 17, 2025 08:35

archanaserver requested a review from evgeni December 17, 2025 08:45

archanaserver force-pushed the cron-rake-tasks branch from 43d493c to dd637c2 Compare December 17, 2025 10:56

evgeni reviewed Dec 18, 2025

View reviewed changes

test/unit/foreman/cron_test.rb Show resolved Hide resolved

pr-processor bot removed the Needs re-review label Dec 18, 2025

evgeni reviewed Dec 19, 2025

View reviewed changes

lib/foreman/cron.rb Show resolved Hide resolved

evgeni reviewed Dec 19, 2025

View reviewed changes

lib/tasks/cron.rake Show resolved Hide resolved

archanaserver force-pushed the cron-rake-tasks branch from dd637c2 to 31c5350 Compare January 6, 2026 12:12

pr-processor bot added the Waiting on contributor label Jan 6, 2026

github-actions bot added the Docs label Jan 6, 2026

evgeni reviewed Jan 7, 2026

View reviewed changes

lib/foreman/cron.rb Outdated Show resolved Hide resolved

archanaserver force-pushed the cron-rake-tasks branch from 63be2cf to a097f83 Compare January 7, 2026 07:42

pr-processor bot added the Needs re-review label Jan 7, 2026

archanaserver force-pushed the cron-rake-tasks branch from a097f83 to ee3ac5d Compare January 7, 2026 07:44

pr-processor bot removed the Waiting on contributor label Jan 7, 2026

archanaserver force-pushed the cron-rake-tasks branch from ee3ac5d to 5ca5a66 Compare January 7, 2026 07:45

pr-processor bot removed the Needs re-review label Jan 7, 2026

evgeni approved these changes Jan 7, 2026

View reviewed changes

shubhamsg199 approved these changes Jan 7, 2026

View reviewed changes

evgeni merged commit c35a101 into theforeman:develop Jan 7, 2026
35 checks passed

	puts "The interval for keeping the Audits is not defined in the settings, exiting..."
	exit 0

	$stdout.puts "Unable to find puppet environment=#{env}"
	exit 1

Fixes #38956 - Add cron rake tasks for recurring jobs #10784

Fixes #38956 - Add cron rake tasks for recurring jobs #10784

Conversation

archanaserver commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

archanaserver commented Dec 9, 2025

Uh oh!

evgeni commented Dec 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

evgeni commented Dec 9, 2025

Uh oh!

archanaserver commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

evgeni commented Dec 12, 2025

Uh oh!

archanaserver commented Dec 15, 2025

Uh oh!

evgeni commented Dec 15, 2025

Uh oh!

archanaserver commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

archanaserver commented Jan 6, 2026

Uh oh!

Uh oh!

evgeni Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

archanaserver Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

evgeni Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

archanaserver Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

shubhamsg199 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

archanaserver commented Nov 27, 2025 •

edited

Loading