Skip to content

Conversation

@tlabaj
Copy link

@tlabaj tlabaj commented Dec 3, 2025

Fixes: 38877

image

@github-actions github-actions bot added the UI label Dec 3, 2025
@tlabaj tlabaj marked this pull request as ready for review December 3, 2025 13:44
@tlabaj tlabaj changed the title WIP: Fixes #38877 - Update donut chart wrapper to pf5 Fixes #38877 - Update donut chart wrapper to pf5 Dec 3, 2025
Copy link
Contributor

@kmalyjur kmalyjur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! I still have 2 proposals:

  • Percentages now default to one decimal place (100.0%), could the default be without it (100%)?
  • When the chart was clickable, the mouse pointer used to change. Could it be added again?

What do you think?

@kmalyjur
Copy link
Contributor

Thank you, now it just needs to be verified

@lhellebr lhellebr self-requested a review January 5, 2026 09:43
};

// PF5 Victory Charts Configuration
export const getDonutChartConfigPF5 = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: getChartConfig should be removed in the future when AreaChart, BarChart, Chart, and LineChart get migrated to PF5.

@lhellebr
Copy link
Contributor

lhellebr commented Jan 6, 2026

FailedQA with foreman-3.18.0-0.20251218213508434273.pr10788.8925.g4e39e2f8a.el9.noarch on Firefox 146.0 build 20251211125526 and Chromium 143.0.7499.169.

  1. Minor issue: just an unexpected change that is OK if confirmed to be intentional. Previously, when hovering over some pie chart part, the other parts were greyed out. Now they don't get greyed out so nothing highlights the part hovered over.

  2. Hovering over a part shows a tooltip immediately and then after half a second, it shows a second - and incorrect - tooltip.

Screenshot From 2026-01-06 16-28-15
  1. Inconsistency between percentage decimal places in different places: in Dashboard, it's 0 decimal places and in REX results old UI, it's 1 decimal place.
    Then in new UI it becomes "1/2 systems" for overall and "1 hosts" for part but that's OK.
    The inconsistency between the first two is something I consider a very minor bug, even more minor because old UI is being deprecated.

Also note that REX new UI has already been using PF5 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants