-
Notifications
You must be signed in to change notification settings - Fork 1k
Fixes #38877 - Update donut chart wrapper to pf5 #10788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
kmalyjur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes! I still have 2 proposals:
- Percentages now default to one decimal place (100.0%), could the default be without it (100%)?
- When the chart was clickable, the mouse pointer used to change. Could it be added again?
What do you think?
2da74c6 to
387c6da
Compare
88cea21 to
735f0b8
Compare
|
Thank you, now it just needs to be verified |
| }; | ||
|
|
||
| // PF5 Victory Charts Configuration | ||
| export const getDonutChartConfigPF5 = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: getChartConfig should be removed in the future when AreaChart, BarChart, Chart, and LineChart get migrated to PF5.

Fixes: 38877