Fixes #39051 - Add expandable info to leapp reports#166
Merged
MariaAga merged 1 commit intotheforeman:masterfrom Feb 16, 2026
Merged
Fixes #39051 - Add expandable info to leapp reports#166MariaAga merged 1 commit intotheforeman:masterfrom
MariaAga merged 1 commit intotheforeman:masterfrom
Conversation
f20e0f3 to
df9db42
Compare
df9db42 to
84dd285
Compare
There was a problem hiding this comment.
Pull request overview
Adds row-level expansion (and an expand-all control) to the Leapp preupgrade report table shown on the job invocation detail page, rendering additional per-entry details when expanded.
Changes:
- Add expandable row rendering for Leapp report entries and manage expanded-row state.
- Introduce a
ReportDetailscomponent to display expanded per-entry metadata (summary/tags/links/remediations). - Add/extend RTL tests to cover section expansion, row expansion, expand-all, pagination, and non-Leapp jobs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| webpack/components/PreupgradeReportsTable/index.js | Implements outer section expansion + inner expandable table rows (including expand-all wiring). |
| webpack/components/PreupgradeReportsTable/tests/PreupgradeReportsTable.test.js | Adds tests for expanded content, expand-all, pagination, and rendering conditions. |
| webpack/components/PreupgradeReportsTable/ReportDetails.js | New expanded-row details renderer (description list with labels/links/remediations). |
| webpack/components/PreupgradeReportsTable/PreupgradeReportsTable.scss | Styles to preserve whitespace in expanded detail descriptions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
webpack/components/PreupgradeReportsTable/__tests__/PreupgradeReportsTable.test.js
Show resolved
Hide resolved
webpack/components/PreupgradeReportsTable/__tests__/PreupgradeReportsTable.test.js
Outdated
Show resolved
Hide resolved
MariaAga
requested changes
Feb 3, 2026
webpack/components/PreupgradeReportsTable/PreupgradeReportsTable.scss
Outdated
Show resolved
Hide resolved
84dd285 to
f0beee4
Compare
f0beee4 to
318fa5a
Compare
318fa5a to
f320e88
Compare
MariaAga
approved these changes
Feb 6, 2026
Member
MariaAga
left a comment
There was a problem hiding this comment.
Thanks! Tested on packing and it works as it should. I think we should wait after feature freeze to get this in, as it looks like a feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds expanding functionality and expandable information to the new Leapp preupgrade report table on the job invocation detail page.
Before:

After:

The test was created with the help of AI.