Merged
Conversation
ofedoren
reviewed
Feb 10, 2026
| "Befehl" | ||
| ], | ||
| "Could not retrieve data: %(status) - %(msg)": [ | ||
| "Could not retrieve data: %(status)s - %(msg)s": [ |
Member
There was a problem hiding this comment.
This looks weird. I see that it was changed in the last PR and it should work, but that's something that might confuse the translator, like it might get perceived as status'es / message's. If this didn't worked before or sprintf doesn't support named parameters, maybe we should just change it to %s - %s?
Member
There was a problem hiding this comment.
Hmm, I guess I just overcomplicate things and translators are aware of this: https://github.com/theforeman/foreman_ansible/pull/782/changes#diff-d9259bf3ade1011a60ac1ef3883267eabb2acf0f049eca0f9ee03833a6a8c831R21
Can be ignored :/
|
Thanks @adamruzicka ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.