Rely on the plugin_manual mechanism in Foreman#820
Open
ekohl wants to merge 1 commit intotheforeman:masterfrom
Open
Rely on the plugin_manual mechanism in Foreman#820ekohl wants to merge 1 commit intotheforeman:masterfrom
ekohl wants to merge 1 commit intotheforeman:masterfrom
Conversation
Member
Author
|
Rebased to resolve a merge conflict, now ready for review. Still includes #819. |
adamruzicka
reviewed
Nov 29, 2023
Member
Author
|
Rebased now that 26b5c4a was merged. It's a bit inconsistent that some parts weren't updated to the new docs. |
Foreman 3.9 fixed this use and it simplifies the code. The plugin already requires Foreman >= 3.10.
Member
Author
|
There are 2 places where it's used: $ rg documentation_button_rex
app/views/job_templates/index.html.erb
5:<% title_actions(documentation_button_rex('3.1JobTemplates'),
app/helpers/remote_execution_helper.rb
57: documentation_button_rex('3.2ExecutingaJob'),
211: def documentation_button_rex(section = '')Given 26b5c4a changed one link to the new documentation, should we align on the new docs instead? |
This was referenced Jul 30, 2024
Contributor
That would be ideal |
Member
Author
|
I don't think I'll have time to find out which sections it should link to so I'd prefer to hand it over then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines #819 and theforeman/foreman#9756.