Conversation
adamruzicka
left a comment
There was a problem hiding this comment.
Could we put all those files being added here into a single directory rather than having them scattered over the repo root, .fmf, plans and tests or is the current structure dictated by tmt?
| - job: tests | ||
| trigger: pull_request | ||
| targets: | ||
| - epel-9 |
There was a problem hiding this comment.
Can this be rhel-9? Alternatively we'll probably need to set up additional repos here
There was a problem hiding this comment.
Can you be more descriptive please I might not get it?
There was a problem hiding this comment.
The previous build failed with this - apparently it tried to build the rpm without having access to the other repositories we supply for the copr_build job.
No matching package to install: 'foreman-assets >= 3.15'
No matching package to install: 'foreman-plugin >= 3.15'
No matching package to install: 'npm(@theforeman/builder) >= 15.0.1'
No matching package to install: 'rubygem(deface)'
No matching package to install: 'rubygem(foreman-tasks) >= 8.3.0'
With the rhel-9 thing, I was hoping that if we used the same target for both of those jobs, things would sort themselves out, but apparently that is not an available target on testing farm, so I'm sorry for that. So back to epel-9 and we'll see where it takes us
There was a problem hiding this comment.
Now we're back where we were, would something like this change anything?
| - epel-9 | |
| epel-9: | |
| additional_modules: "foreman-devel:el9" | |
| additional_repos: | |
| - https://yum.theforeman.org/releases/nightly/el9/x86_64/ | |
| - https://yum.theforeman.org/plugins/nightly/el9/x86_64/ |
There was a problem hiding this comment.
i guess this is what i saw missing, trying it for now...
There was a problem hiding this comment.
968e68d this seems to be the way forward. It will at least allow the test job to be triggered in testing farm
Thanks for the review @adamruzicka and for pointing this out! |
|
Failed to load packit config file: For more info, please check out the documentation or contact the Packit team. You can also use our CLI command |
|
@adamruzicka i see some failures, could you help me understand if these are expected issues because of this changes? |
|
The failures in unit tests through github actions are unrelated to the changes proposed here. The testing-farm failure however, is related. If I'm reading it right, then packit builds a package, then testing farm spins up a standard centos9stream machine and tries to install the packit-built rpm there, but since this is a foreman plugin, the rpm cannot be installed on its own. |
| provision: | ||
| how: virtual | ||
| image: centos-stream-9 | ||
|
|
There was a problem hiding this comment.
prepare:
how: install
package:
- https://yum.theforeman.org/releases/nightly/el9/x86_64/foreman-release.rpm
should setup enough repos to make things install fine
|
The plan on this is unclear right now, so moving it to draft for now. |
No description provided.