Skip to content

add recurring task for foreman_tasks:cleanup#298

Open
archanaserver wants to merge 1 commit intotheforeman:masterfrom
archanaserver:recurring-foreman-tasks-cleanup
Open

add recurring task for foreman_tasks:cleanup#298
archanaserver wants to merge 1 commit intotheforeman:masterfrom
archanaserver:recurring-foreman-tasks-cleanup

Conversation

@archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Nov 13, 2025

based on #288

@archanaserver archanaserver mentioned this pull request Nov 13, 2025
Merged
@evgeni
Copy link
Member

evgeni commented Dec 12, 2025

needs a rebase

@archanaserver archanaserver force-pushed the recurring-foreman-tasks-cleanup branch from f2abc1a to 4e0e173 Compare December 17, 2025 10:50
shubhamsg199
shubhamsg199 reviewed Jan 7, 2026
View reviewed changes
Copy link

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add foreman_tasks-cleanup

foremanctl/tests/foreman_test.py

Line 8 in fed186b

RECURRING_INSTANCES = [
to test it ?

@archanaserver
Copy link
Contributor Author

archanaserver commented Jan 12, 2026

Add foreman_tasks-cleanup

foremanctl/tests/foreman_test.py

Line 8 in fed186b

RECURRING_INSTANCES = [

to test it ?

We have done it differently here #332 that is updated all foreman_recurring_tasks defaults to define 4 generic timers - hourly/daily/monthly/weekly, and already updated in the code: https://github.com/theforeman/foremanctl/pull/332/changes#diff-7612c05b101886651a830b2c496b50ad3959fc70240ba81639ece01f09a093bcR8-R12 so we'll wait for that to get in to proceed with this PR and #299

@archanaserver archanaserver force-pushed the recurring-foreman-tasks-cleanup branch 2 times, most recently from 12f6e59 to 3f0331a Compare February 27, 2026 13:13
@archanaserver archanaserver force-pushed the recurring-foreman-tasks-cleanup branch from 3f0331a to c6265e7 Compare February 27, 2026 13:14
@archanaserver archanaserver requested a review from evgeni February 27, 2026 13:15
@shubhamsg199
Copy link

shubhamsg199 commented Mar 2, 2026

@archanaserver Can you check the failing rpm-build?

@evgeni
Copy link
Member

evgeni commented Mar 3, 2026

Given theforeman/foreman-tasks#794 is merged, I think we can just close this PR as not required anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 left review comments

@evgeni evgeni Awaiting requested review from evgeni

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archanaserver @evgeni @shubhamsg199