Improve support for Foreman_proxy AD integration#429
Improve support for Foreman_proxy AD integration#429fatmcgav wants to merge 2 commits intotheforeman:masterfrom
Conversation
…= ad' Created a new 'Foreman_proxy::AdConfig' datatype Add test coverage.
fatmcgav
changed the title
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I like the general direction of this. I'll need to look into the kafo issue to prevent our installer from breaking.
| Enum['freeipa', 'ad'] $realm_provider = $::foreman_proxy::params::realm_provider, | ||
| Stdlib::Absolutepath $realm_keytab = $::foreman_proxy::params::realm_keytab, | ||
| String $realm_principal = $::foreman_proxy::params::realm_principal, | ||
| Optional[Foreman_proxy::AdConfig] $ad_config = $::foreman_proxy::params::ad_config, |
There was a problem hiding this comment.
We still have an issue in our installer with a Struct because of Kafo. theforeman/puppet-foreman#601 was limited by the same issue. I still need to look into this.
manifests/init.pp
Outdated
| Boolean $realm = $::foreman_proxy::params::realm, | ||
| Foreman_proxy::ListenOn $realm_listen_on = $::foreman_proxy::params::realm_listen_on, | ||
| String $realm_provider = $::foreman_proxy::params::realm_provider, | ||
| Enum['freeipa', 'ad'] $realm_provider = $::foreman_proxy::params::realm_provider, |
There was a problem hiding this comment.
I'd prefer to keep this as a string since that allows third party plugins to still use the same infra.
There was a problem hiding this comment.
Sure, I can tweak that back...
|
@ekohl Cheers for the quick review... |
|
Looks like I forgot this. Looking back I'm wondering if this is a good idea. We don't expose any plugin options on the top level and it should already be possible to pass in all the parameters. I certainly like the inclusion of the AD module if that's the provider. For the specific options we can also expose the plugin in the installer. |
3 participants
Include 'foreman_proxy::plugin::realm::ad' class if 'realm_provider = ad'
Created a new 'Foreman_proxy::AdConfig' datatype
Add test coverage.
TODO: