Merged
Conversation
daf06a6 to
57cccda
Compare
1db81cd to
14ae15f
Compare
ekohl
reviewed
Dec 1, 2025
Member
ekohl
left a comment
There was a problem hiding this comment.
Perhaps first introduce a shared example in its own commit? I suspect the following in spec/support/acceptance/examples.rb works.
shared_examples 'with feature' do |feature|
let(:feature) { feature }
cert_dir = '/etc/foreman-proxy'
describe curl_command("https://#{host_inventory['fqdn']}:8443/features", cacert: "#{cert_dir}/certificate.pem", cert: "#{cert_dir}/certificate.pem", key: "#{cert_dir}/key.pem") do
its(:stdout) { should include(feature) }
its(:exit_status) { should eq 0 }
end
endThen you can build on that in openbolt.
spec/acceptance/discovery_spec.rb
Outdated
| describe command('curl -sk https://127.0.0.1:8443/features | grep -q discovery') do | ||
| cert_dir = '/etc/foreman-proxy' | ||
| describe curl_command("https://#{host_inventory['fqdn']}:8443/features", cacert: "#{cert_dir}/certificate.pem", cert: "#{cert_dir}/certificate.pem", key: "#{cert_dir}/key.pem") do | ||
| its(:stdout) { should match('discovery') } |
Member
There was a problem hiding this comment.
It probably doesn't matter a lot, but I wonder if include is semantically better.
Suggested change
| its(:stdout) { should match('discovery') } | |
| its(:stdout) { should include('discovery') } |
Member
|
I submitted that in #888 because I wanted to see if it worked. |
Member
Author
|
I cherry-picked your shared example and just applied it to openvox for now, so CI can pass |
Every plugin is expected to expose a feature which means it works. This uses a shared example to test it in various places.
ekohl
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.