Add clip child offsets and native carousel demo#6
Closed
rauhryan wants to merge 4 commits intothefrontside:mainfrom
Closed
Add clip child offsets and native carousel demo#6rauhryan wants to merge 4 commits intothefrontside:mainfrom
rauhryan wants to merge 4 commits intothefrontside:mainfrom
Conversation
commit: |
cowboyd
reviewed
Apr 11, 2026
Member
cowboyd
left a comment
cowboyd
left a comment
There was a problem hiding this comment.
Looking good. Seems like there is a formatting error
Comment on lines
-1
to
+4
| CC = clang | ||
| LLVM_CLANG := $(shell if [ -x /opt/homebrew/opt/llvm/bin/clang ]; then printf %s /opt/homebrew/opt/llvm/bin/clang; elif [ -x /opt/homebrew/bin/clang ]; then printf %s /opt/homebrew/bin/clang; else command -v clang; fi) | ||
| CC = $(LLVM_CLANG) | ||
| LLVM_BIN_DIR := $(shell dirname "$(LLVM_CLANG)") | ||
| WASM_LD_DIR ?= $(shell if command -v wasm-ld >/dev/null 2>&1; then dirname "$$(command -v wasm-ld)"; elif [ -x /opt/homebrew/bin/wasm-ld ]; then printf %s /opt/homebrew/bin; fi) |
Comment on lines
-22
to
+25
| $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(SRC) | ||
| PATH="$(LLVM_BIN_DIR):$(WASM_LD_DIR):$$PATH" $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(SRC) |
Member
There was a problem hiding this comment.
Something is whack here, let's figure it out.
Comment on lines
+77
to
+80
| childOffset: Type.Optional(Type.Object({ | ||
| x: Type.Optional(Type.Number()), | ||
| y: Type.Optional(Type.Number()), | ||
| })), |
Member
There was a problem hiding this comment.
Are x,y allowed to be negative?
Author
|
Superseded by a clean PR that separates the core changes from demos. The clip childOffset work, floating parameter expansion, transition support, and element bounds API are now in separate, focused commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clip.childOffsetthrough the TypeScript ops layer, validator, and WASM bridge so clipped containers can translate their childrenTesting
make && deno test --allow-read test/term.test.ts test/pointer.test.tsdeno check carousel-demo/main.tsscript -q /dev/null env CLAYTERM_SMOKE_TEST=1 deno run -A carousel-demo/main.ts