Skip to content
This repository was archived by the owner on Feb 13, 2019. It is now read-only.

Conversation

@collin
Copy link
Contributor

@collin collin commented Nov 9, 2016

The button was detaching before clicktracking was able to find the category/action/label.

@kand @spra85

@spra85
Copy link
Contributor

spra85 commented Nov 9, 2016

@collin, intentional to include changes to the bulbs.poll test in this PR?

@collin
Copy link
Contributor Author

collin commented Nov 10, 2016

@spra85 Yeah, I've been trying to figure out some flaky tests. Looks like it isn't quite there yet :(

Copy link
Contributor

@spra85 spra85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approving @collin, will defer to you if it makes sense for the bulbs-poll test to be pushed out with this or if you're still looking at fixing the flaky tests separately

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants