breaking: split history schemas out of main schema pkg#1729
Merged
golanglemonade merged 6 commits intomainfrom Dec 18, 2025
Merged
breaking: split history schemas out of main schema pkg#1729golanglemonade merged 6 commits intomainfrom
golanglemonade merged 6 commits intomainfrom
Conversation
a6b6f36 to
c28537c
Compare
eeee6bd to
f8a166c
Compare
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
f8a166c to
176ecb2
Compare
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
🔧 Configuration Changes DetectedThis PR contains changes that will affect the Helm chart configuration. A draft infrastructure PR has been automatically created to preview these changes: 📋 Draft PR: https://github.com/theopenlane/openlane-infra/pull/540 Changes Preview:✅ Updated ConfigMap template The infrastructure PR will automatically convert from draft to ready for review once this core PR is merged. |
|
matoszz
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Breaking Change - Part 1
historyschemas to be moved to it's own package, allowing for simplier client + dramatically decreases the size of the maingeneratedpackageaccessmapto it's ownauthzgeneratedpackage. The other authz generated files cannot be moved due to the pointer receiver variable being fromgeneratedhttp://localhost:17608/history/queryhistorydata to justviewaccess of the objectWhen looking at the PR you should see mostly removals from
internal/ent/generated/*files forhistoryschemas; and net-new files ininternal/ent/historygenerated/There is a new
commonpackage ininternal/graphapi/common/that contains the common functions used by both the main resolvers and history resolvers.Note:
Other changes:
query simplefor released client generation, this will be updated and ensure its up-to-date in https://github.com/theopenlane/go-client nextgo-generate-fastand just uses the checksum generation for consistencyhistoryfunctions from the cli; this is inline with feat: cli refactor #1563 which will be done as a follow-up as wellAuditingandhistory_queryis currently disabled; this requires some rework due to needing to be thehistorygeneratedpackage but the templates need to be ingeneratedbecause they are hooks. Neither of these are currently in use so should not affect production while this is reworked.Follow-ups:
sharedpackage to prevent cyclical depsStill some more imporvements we can do but better than before:
before: