Skip to content

breaking: move cli to it's own go module, remove openlaneclient#1756

Merged
golanglemonade merged 16 commits intomainfrom
breaking-core-jobs-cli
Dec 27, 2025
Merged

breaking: move cli to it's own go module, remove openlaneclient#1756
golanglemonade merged 16 commits intomainfrom
breaking-core-jobs-cli

Conversation

@golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Dec 24, 2025

  • removes all history cli commands
  • moves openlane-cli (/cli) to it's own go module so it no longer requires the compile of the entire core repo
  • moves to the new go-client - this is currently a branch tag because of cyclical deps - I need to merge on of these PRs first, tag, merge the other and then go back and update the first
  • moves everything that is used in go-client to common so that we no longer have external deps in core in go-client. I'll review other repos later to prevent the same thing
  • adds go.work - the go:tidy task command has been alias'ed to the go work sync task command, which should generally be used in a go mono-repo with multiple go mods
  • cli commands updated for pagination

Note: I haven't pulled in the new cli from here #1563 yet to avoid changes as simple as possible

Related: theopenlane/go-client#8

Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade marked this pull request as ready for review December 27, 2025 03:16
@golanglemonade golanglemonade requested a review from a team as a code owner December 27, 2025 03:16
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2.1% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade enabled auto-merge (squash) December 27, 2025 04:53
@golanglemonade golanglemonade merged commit 215c0c5 into main Dec 27, 2025
18 of 19 checks passed
@golanglemonade golanglemonade deleted the breaking-core-jobs-cli branch December 27, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants