Open
Conversation
Achiket123
requested review from
LemonAid711,
adelowo and
theopenlane-bender
github-actions
bot
added
enhancement
| @@ -0,0 +1,586 @@ | |||
| // Code generated by 'entc generate'. DO NOT EDIT. | |||
Member
There was a problem hiding this comment.
@Achiket123 this shouldn't be committed; it is part of the generate process but should be automatically removed when entc is complete
Comment on lines
-115
to
121
| rule.AllowQueryIfSystemAdmin(), | ||
| policy.CheckOrgReadAccess(), | ||
| ), | ||
| policy.WithMutationRules( | ||
| policy.AllowCreate(), | ||
| ), | ||
| policy.WithOnMutationRules(ent.OpUpdate|ent.OpUpdateOne|ent.OpDelete|ent.OpDeleteOne, | ||
| rule.AllowMutationIfSystemAdmin(), | ||
| policy.CheckOrgWriteAccess(), | ||
| ), |
Member
There was a problem hiding this comment.
The privacy rules shouldn't need to be changed for this; csv already works properly as is.
The job is setup with a system-admin token and uses user impersonation to pull the data the user has access to.
Member
golanglemonade
left a comment
golanglemonade
left a comment
There was a problem hiding this comment.
The addition of the export types look good; comments on a few other things that shouldn't be updated/included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @golanglemonade please review these and please tell me if there is any thing else i need to change.
Thankyou.