Skip to content

Replace inline namespace with implicitly imported namespace #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garyscavone merged 2 commits into from
Nov 23, 2025
Merged

Replace inline namespace with implicitly imported namespace #468

garyscavone merged 2 commits into from
Nov 23, 2025

Conversation

@mikomikotaishi
Copy link
Contributor

@mikomikotaishi mikomikotaishi commented Nov 22, 2025 •
edited
Loading

This pull request replaces inline namespace with a strict namespace, which avoids additional preprocessor logic in the module file, and adds using namespace rt::audio; unless RTAUDIO_USE_NAMESPACE is enabled (to avoid breaking code that accesses rt::audio classes through the global namespace).

@mikomikotaishi mikomikotaishi changed the title Fix bug in module inline namespace feature Replace inline namespace with implicitly imported namespace Nov 22, 2025
@garyscavone garyscavone merged commit 4bc3730 into thestk:master Nov 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikomikotaishi @garyscavone