Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate all packages to dual ESM/CJS builds using
tsdown, and add CJS entry points forreact-ui. This eliminates the need fortranspilePackagesin Next.js andbuild.transpilein Nuxt, fixing the friction reported in #360 where consumers had to manually configure their bundlers to use OpenUI packages.fixes point 3 in #360
Changes
lang-core,react-lang,react-headless,react-email, andopenui-clibuilds fromtsctotsdownwith dual ESM (.mjs) + CJS (.cjs) output and co-located type declarations (.d.mts,.d.cts)react-ui(viatsdown) alongside its existingtsc-based ESM build for the.and./genui-libentry pointspackage.jsonexportsmaps across all packages with properimport/requireconditional exportsreact-headlessexportsfield and"type": "module"(was previously CJS-only with no exports map)typecheck,check:publint, andcheck:attwscripts to each packagetsdown,publint, and@arethetypeswrong/clias root devDependenciestranspilePackagesfrom all Next.js example/docs configs andbuild.transpilefrom the Nuxt example config*.config.tsfilesTest Plan
pnpm buildand confirmed dual-format output files existpublintandattwchecks against built packagesvitest run) forlang-core,react-lang,react-headlesstranspilePackages