Ensure tessellation of polygon2 returns a collection of triangle2#89
Open
dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
Open
Ensure tessellation of polygon2 returns a collection of triangle2#89dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
Conversation
The return type of ITessellate tessellate for Circle, Triangle2, and Rect all return a collection of Triangle2. However, calling tessellate on a polygon returned a collection of point triplets. This patch ensures uniformity in the return type for tessellating 2d shapes.
Contributor
Author
|
Note that it appears that all of the 3d shapes return g/faces (which is a collection of Vec3 points), except for geom/quad which returns a set of Triangle3. So it might be useful to ensure uniformity there too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return type of ITessellate tessellate for Circle, Triangle2, and Rect all
return a collection of Triangle2. However, calling tessellate on a polygon returned a
collection of point triplets. This patch ensures uniformity in the return type
for tessellating 2d shapes.