Prevent multiple spaces in sysctl value#67
Open
mathiasaerts wants to merge 2 commits intothias:masterfrom
Open
Prevent multiple spaces in sysctl value#67mathiasaerts wants to merge 2 commits intothias:masterfrom
mathiasaerts wants to merge 2 commits intothias:masterfrom
Conversation
|
Please merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting a sysctl value that consists of multiple numbers (like
net.ipv4.ip_local_port_range, with a value like1024 65535), the configured value will be 'enforced' on every puppet run, since the output ofsysctl -nwill display the output with a tab character instead of a single space.To prevent the value from being set on every puppet run, I've added a sed command to replace multiple spaces (or tabs) with a single space when comparing the current value.