refactor: Improve argument parsing in readContract function #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readContract function in the src/server/routes/contract/read/read.ts file has been refactored to improve the parsing of arguments. Previously, the function split the arguments string by comma and mapped each argument. Now, the function first tries to parse the arguments as a JSON array. If successful, it uses the parsed arguments. If parsing fails, it falls back to the previous method of splitting the string.
This change improves the flexibility and reliability of argument parsing in the readContract function.
PR-Codex overview
This PR focuses on enhancing the argument parsing logic in the
readfunction and improving the handling ofBigNumbervalues in thebigNumberReplacerfunction. Additionally, it introduces new tests for reading contract methods with structured parameters.Detailed summary
src/server/routes/contract/read/read.tsto use JSON parsing as the primary method, with a fallback to string splitting.bigNumberReplacerinsrc/server/utils/convertor.tsfromstringtoany.bigNumberReplacer.test/e2e/tests/read.test.tsfor reading contract methods with structured parameters.