Skip to content

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Nov 1, 2024

PR-Codex overview

This PR focuses on enhancing error handling in the read function of the contract and adding a new test case to verify the behavior when reading a contract with incorrect parameters.

Detailed summary

  • Added a new test case in test/e2e/tests/read.test.ts for handling incorrect contract reads, expecting a 400 error.
  • Improved error handling in src/server/routes/contract/read/read.ts to throw a custom error for specific function call issues.
  • Updated return type for returnData to unknown and used as any for the response.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr d4mr changed the title 400 for user errors 400 for user errors on contract read Nov 1, 2024
@d4mr d4mr merged commit 07b29de into main Nov 1, 2024
5 checks passed
@d4mr d4mr deleted the pb/read-400 branch November 1, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants