Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Nov 2, 2024

PR-Codex overview

This PR focuses on removing the @fastify/express and @fastify/cookie packages from the project, along with related middleware and types, while updating the yarn.lock file accordingly.

Detailed summary

  • Deleted @fastify/cookie and @fastify/express from package.json.
  • Removed withExpress middleware from src/server/index.ts.
  • Updated import paths in src/server/index.ts to use node: prefix for built-in modules.
  • Adjusted yarn.lock to reflect the removal of the deleted packages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr
Copy link
Contributor

d4mr commented Nov 4, 2024

I did a scan for fastify.use(*) and don't see anything. As I understand this means it should be safe to remove the plugin. Is there a more straightforward way to ensure nothing depends on this?

@arcoraven arcoraven merged commit b5f54bf into main Nov 4, 2024
5 checks passed
@arcoraven arcoraven deleted the ph/removeFastifyExpress branch November 4, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants