chore: Show min amount needed if out of funds #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Nov 6, 2024
| return stringify(error); | ||
| }; | ||
|
|
||
| export const prettifyTransactionError = async ( |
Contributor
Author
There was a problem hiding this comment.
This function was used to prettify an error. But the "simulate" step below wasn't used since v5 isn't returning ethers error codes anymore. Moving the insufficient funds logic inline in SendTransactionWorker.
d4mr
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing error handling in the codebase. It introduces a new function
wrapErrorto standardize error messages and updates several parts of the code to utilize this new function, improving clarity and consistency in error reporting.Detailed summary
wrapErrorfunction to standardize error messages.prettifyErrorfunction for concise error message formatting.prettifyErrorwithwrapErrorin error handling logic across several functions._sendUserOpand_sendTransactionto include specific insufficient funds messages.